casper-network / casper-network/casper-node

Revisit fn register_finality_signature() in BlockAcceptor

Open
#4,055 0 comments 0 reactions 0 assignees View on GitHub
tech-debt triage
Dominant language
Rust
Stars
399
Forks
224
Avg merge
15h 44m
Merged PRs (30d)
2

Description

At least two potential optimizations have been spotted:

1. crypto verification is done at the early stage - should be at the very end
2. check for meta_block.block.header().era_id() != finality_signature.era_id should probably be done ~later~ earlier
There might be other potential improvements available.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.