casper-network / casper-network/casper-node

adding casper-deploy-generator to CI test-vectors

Open
#3,867 0 comments 0 reactions 1 assignee Assigned to @sacherjj View on GitHub
Dominant language
Rust
Stars
399
Forks
224
Avg merge
15h 44m
Merged PRs (30d)
2

Description

Recently I had to add some new features to casper-deploy-generator ([link](https://github.com/casper-ecosystem/casper-deploy-generator)) and the [first PR ](https://github.com/casper-ecosystem/casper-deploy-generator/pull/61)became a maintanence one - updating deps, fixing compilation issues etc (there were actually new Key variants that were not covered by the Ledger app so far which is already a soft warning). Can we add a step to CI in the node repo that will clone casper-deploy-generator , runs make test-vectors and verify that there are no changes in the diff for that file? This should help with catching any changes that would break the Ledger app compatibility

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.