casper-network / casper-network/casper-node

*Add into_* methods to StoredValue.*

Open
#3,801 0 comments 0 reactions 1 assignee Claimed by @mpapierski View on GitHub
low-priority triage
Dominant language
Rust
Stars
399
Forks
224
Avg merge
15h 44m
Merged PRs (30d)
2

Description

Currently there is a set of as_* methods on the StoredValue type, which allows for a reference-cast into a specific type. These should be complemented with into_* methods, which take self instead of &self, as there are some places in the codebase where as_foo().cloned() is used when a into_foo() would be better.
This issue is about adding all the missing methods (likely one for each as_* method), as well as examining all callsites in at least the node code and checking whether an into_method fits better.

for background, see this link: https://casper-labs-team.slack.com/archives/C02BSLUGUGM/p1679829582676949

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.