cashapp / cashapp/hermit

Hermit fails to infer OS when 'osx' is used as the OS

Open
#285 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
927
Forks
111
Avg merge
7m
Merged PRs (30d)
1

Description

$ hermit manifest create https://github.com/github/gh-ost/releases/download/v1.1.4/gh-ost-binary-osx-amd64-20220225143506.tar.gz
fatal:hermit: https://github.com/github/gh-ost/releases/download/v1.1.4/gh-ost-binary-osx-amd64-20220225143506.tar.gz: could not infer OS

osx seems like a perfectly cromulent OS to infer, but it looks like the code only recognizes darwin or linux

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in manifest/infer.go at the OS inference logic linked in the issue, then reproduce the command with the gh-ost osx archive. Confirm that osx archives infer an OS successfully while existing darwin and linux inference continues to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.