casey / casey/x-serialization-format

Check that `Size::check` fails for large sizes on 16 and 32 bit platforms

Open
#30 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

It must be possible to convert `Size` values to `usize` values. Thus, if a `Size` would overflow a `usize`, `Size::check` should return an error.

`Size` is currently represented as a `U64`, so `Size::check` will always succeed on 64 bit platforms. However, conversions could fail on 16 bit and 32 bit platforms.

Figure out a way to test the conversions on these platforms. Ideally via CI. I should also check that types containing an invalid `Size` also fail.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.