casey / casey/odin

Old `executable-path` relies on internals of Cargo and will break with existing / upcoming features

Open
#12 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Tests assumes the location of build artifacts
- This isn't the case when a user sets `build.build-dir` (added as of Cargo 1.91)
- This isn't the case if we approve the new `build-dir` layout (https://github.com/rust-lang/cargo/issues/15010)
- This isn't the case if we change the `build.build-dir` default (https://github.com/rust-lang/cargo/issues/16147)

You can reproduce this by running either:
```console
$ cargo +nightly test -Zbuild-dir-new-layout
$ CARGO_BUILD_BUILD_DIR=build cargo test
```

Upgrade to the latest version of `executable-path` for it to work (https://github.com/casey/executable-path/issues/2).

This problem was identified by the following crater run: https://github.com/rust-lang/rust/pull/149852

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.