casey / casey/intermodal

Serialize announce URLs as `Url` instead of `String`

Open
#433 0 comments 0 reactions 0 assignees View on GitHub
reform
Dominant language
Rust
Stars
659
Forks
36
Avg merge
18m
Merged PRs (30d)
2

Description

Announce URLs are serialized as `String`, instead of `Url`. I'm not sure why I do this, since `Url` supports serde with the `serde` feature enabled.

I'm inclined to start serializing URLs as `Url`, instead of `String`, since it is slightly less error prone. However, this would cause some torrents with invalid announce URLs to stop deserializing correctly. I think this is rare, but I'm still on the fence about whether or not this downside is worth it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.