casesandberg / casesandberg/react-color

Chrome hsla - saturation and lightness change event not fired

Open
#408 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
12.3k
Forks
920
PR merge metrics
No merged PRs in 30d

Description

I am seeing an issue in the chrome picker where changing the `s` or `l` input of the hsla inputs does not call the `onChange` event.

I can reproduce on the react-color storybook, but not on the main feature/doc site.
Steps
- go to chrome story in storybook
- click through color formats in picker to get to hsla inputs
- change the lightness value
- click away from the lightness input to blur it

Expected
- onChange event was called with new lightness value, new lightness value displays as value of `l` input.

Actual
- `l` input value seems to be the same as the 'b' value in the rgba inputs.
- adding a log statement in the onChange callback shows that it is never called. When I change the
hue or alpha values it is called.

Contributor guide

Open the contributing guide

Research direction

Start with the Chrome picker story in Storybook and reproduce the issue by switching to the hsla inputs, changing lightness, and blurring the field. Trace the hsla input change handling and compare it with hue and alpha; done means the lightness value is displayed correctly and onChange receives the updated value.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react, storybook
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.