carvel-dev / carvel-dev/vendir

Support dangerousSkipTLSVerify option when fetching from http server.

Open
#292 2 comments 0 reactions 1 assignee Claimed by @vmunishwar View on GitHub
enhancement
Dominant language
Go
Stars
399
Forks
73
Avg merge
2h 53m
Merged PRs (30d)
2

Description

**Describe the problem/challenge you have**

I need to use vendir to download files from a web server but the web server uses self signed certificates. This will fail as vendir will verify certificates when using `http`. Docs do not give an example to say can disable this check so assume you can't.

**Describe the solution you'd like**

Add `dangerousSkipTLSVerify` option to `http` section.

``` # fetches asset over HTTP (optional)
http:
# asset URL (required)
url:
# verification checksum (optional)
sha256: ""
# specifies name of a secret with basic auth details;
# secret may include 'username', 'password' keys (optional)
secretRef:
# (required)
name: my-http-auth
# skip unpacking tar, tgz, and zip files; by default files are unpacked (optional)
disableUnpack: false

# specify wether to skip TLS verification; defaults to false
dangerousSkipTLSVerify: false
```

**Anything else you would like to add:**

Should also be added to `kapp-controller` to keep parity.

---
Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.