carvel-dev / carvel-dev/kapp

Cache app names while printing ownership errors

Open
#998 0 comments 0 reactions 1 assignee Claimed by @devacts View on GitHub
carvel accepted enhancement
Dominant language
Go
Stars
1.1k
Forks
134
PR merge metrics
No merged PRs in 30d

Description

**Describe the problem/challenge you have**
Today `kapp` makes a call per resource when it encounters multiple resources owned by another app. This can be a an issue if a PackageInstall is constantly failing with this error for multiple resources.

**Describe the solution you'd like**
We are already building a map while snatching ownership from specified apps. We can reuse this to mitigate this risk.

**Anything else you would like to add:**
There is a very slight chance of an app being created after we have cached the information. But it is an unlikely race condition, and the only downside is that app won't be named in the error message. This will change in the next reconciliation when the name is cached.

---
Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.