carvel-dev / carvel-dev/kapp

Custom waitRules should work with default waiting rules of other resources like deployments

Open
#512 1 comment 1 reaction 0 assignees View on GitHub
carvel accepted enhancement
Dominant language
Go
Stars
1.1k
Forks
134
PR merge metrics
No merged PRs in 30d

Description

**Describe the problem/challenge you have**
When I provide a custom `waitRule` for resources like Deployment, ReplicaSet, etc,. then the default waiting behaviour provided by kapp doesn't work. This is because we [return early](https://github.com/vmware-tanzu/carvel-kapp/blob/develop/pkg/kapp/clusterapply/converged_resource_factory.go#L47) when a custom waiting resource is found.

**Describe the solution you'd like**
The default waiting rules should work well with custom waiting rules. It would be interesting to figure out which one should have more precedence when both specify the same condition.

**Anything else you would like to add:**

---
Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.