carvel-dev / carvel-dev/kapp

Lcs col is not updated to true when deploy failed, but recovered

Open
#467 3 comments 1 reaction 0 assignees View on GitHub
bug carvel accepted
Dominant language
Go
Stars
1.1k
Forks
134
PR merge metrics
No merged PRs in 30d

Description

**What happened:**

> `Lcs` appears to be inconsistently reported in the `kapp list -A` output when kapp-controller fails to install an app and then subsequently is made to succeed. (Needs reproduction/confirmation)

this is probably because Lcs is set to false on the failed deploy, eventually resources succeed reconciling and subsequent kapp deploy results in being a noop (no changes). i dont believe in this case we "double check" that Lcs is switched back to true because we do not generate new app change -- should we?

**Environment:**

- kapp version (use `kapp --version`):
- OS (e.g. from `/etc/os-release`):
- Kubernetes version (use `kubectl version`)

---
Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.