carvel-dev / carvel-dev/kapp

Refine conditions column presentation/meaning

Open
#164 3 comments 0 reactions 0 assignees View on GitHub
discussion
Dominant language
Go
Stars
1.1k
Forks
134
PR merge metrics
No merged PRs in 30d

Description

I'm trying out the Application CRD (see https://github.com/kubernetes-sigs/application) which has by default a couple of conditions, i.e.:

```yaml
conditions:
- lastTransitionTime: "2020-11-17T16:55:57Z"
lastUpdateTime: "2020-11-17T16:55:57Z"
message: all components ready
reason: ComponentsReady
status: "True"
type: Ready
- lastTransitionTime: "2020-11-17T16:55:57Z"
lastUpdateTime: "2020-11-17T16:55:57Z"
message: No error seen
reason: NoError
status: "False"
type: Error
```
The latter is unusual but not unheard of, being given as a possibility in https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties.

I was expecting from your documented "wait for all conditions to turn True" in https://github.com/vmware-tanzu/carvel-kapp/blob/develop/docs/apply-waiting.md for this to cause a problem waiting for apply to finish - but luckily kapp 0.34.0 doesn't seem to, so far at least...

It does however show up as a red `1/2 t` entry in the Conds column when inspecting/applying/diffing, which is a user-experience annoyance.

I'm not sure if you can rely on any condition of type `Error` to be "normal-false" as sounds plausible to me, or if there is any annotation/kapp config I can apply to work around this wrinkle...

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.