carvel-dev / carvel-dev/kapp-controller

Package.Spec.SyncPeriod should be respected when PackageInstall.Spec.SyncPeriod is nil

Open
#710 5 comments 0 reactions 0 assignees View on GitHub
awaiting-input discussion
Dominant language
Go
Stars
323
Forks
127
Avg merge
2d 16h
Merged PRs (30d)
4

Description

**What steps did you take:**
When applying a PackageInstall CR with Spec.SyncPeriod == nil.

**What happened:**
The generated App.Spec.SyncPeriod is 10min.

**What did you expect:**
Package.Spec.Template.Spec.SyncPeriod (if not nil) should be respected when PackageInstall.Spec.SyncPeriod is nil.
Because each Package knows its proper SyncPeriod and deploy.kapp.RawOptions.'--wait-timeout=30s', unless PackageInstall CR explicitly sets the SyncPeriod.

**Anything else you would like to add:**
Here is the code causing the issue: https://github.com/vmware-tanzu/carvel-kapp-controller/blob/v0.36.1/pkg/packageinstall/app.go#L46-L52

**Environment:**

- kapp Controller version: v0.36.1 and develop branch

---
Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.