carvel-dev / carvel-dev/imgpkg

Add automated testing against well known registries on commits and releases

Open
#138 7 comments 1 reaction 0 assignees View on GitHub
carvel accepted enhancement
Dominant language
Go
Stars
284
Forks
70
PR merge metrics
No merged PRs in 30d

Description

### Acceptance Criteria:
**As a contributor to imgpkg**
I want to have confidence that my changes did not introduce inconsistent behavior on different registries.

**When a new commit is pushed to imgpkg**, I expect to see github actions running integration tests on:
- [x] Harbor
- [x] GCR

**When a new release of imgpkg is cut**, I expect to see github actions running integration tests on:
- [x] Harbor
- [x] GCR
- [ ] https://cloud.google.com/artifact-registry
- [ ] DockerHub

**Notes:**
- Since DockerHub has rate limiting, running the integration tests only during a release is sufficient.
- For the integration with harbor, Joao found that we could stand up an instance using https://github.com/bitnami/bitnami-docker-harbor-portal/blob/master/docker-compose.yml, so maybe we could just start a container to do this.
- **Feel free to tackle this work all at once, or one registry at a time using 3 different PRs.**
- in fact, if supporting GCR and DockerHub is not "just" an incremental investment, consider whether it makes sense to tackle those registries, later.

👇🏻 Original request👇🏻

---

- **Describe the problem/challenge you have**
As a user, I want to be sure that `imgpkg` works with different registries

---
**Describe the solution you'd like**
When testing `imgpkg` using Github action, we should try to test against a local registry and against more widely spread registries, like gcr, harbor, and dockerhub.

**Anything else you would like to add:**
I spun up this issue from #131, thanks for the idea @DennisDenuto
For this issue, we should do the following:
- [x] Run integration tests against a gcr instance
- [x] Run integration tests against an Harbor instance
- Is there a Harbor instance that we can use?
- Should we instantiate a Harbor instance and use it for testing?
- Can we run Harbor as a container similar to what we are doing with the registry:2?
- [ ] Run integration tests against a dockerhub, we should be careful about this due to rate limiting. Maybe we could consider running these tests as part of a Release process

---
Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.