carrevue / carrevue/OpenSB

let the router handle dynamic files

Open
#314 0 comments 0 reactions 0 assignees View on GitHub
backburner
Dominant language
PHP
Stars
10
Forks
5
PR merge metrics
No merged PRs in 30d

Description

the sb router already handles things like loading skin thumbnails and loading a file from the composer vendor folder through the ``load_thumbnail_from_skin()`` and ``load_file_from_vendor()`` functions, so I wonder why cant it also handle dynamic files (videos, profile pictures, thumbnails, etc)

PROS:
* hide private uploads
* hide uploads that require to be logged in from logged out users

CONS:
* adds overhead, would make the site a bit slower
* would fuck up with sb production instance's usage of nginx ratelimits.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the SB router and its existing load_thumbnail_from_skin() and load_file_from_vendor() paths. Define which dynamic files require routing and authentication, then resolve the stated nginx ratelimit and performance tradeoffs before implementation; done criteria are not specified in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.