carpentries / carpentries/amy

Email templates without a 'no-reply' address set fail when used in actions

Open
#2,425 0 comments 0 reactions 0 assignees View on GitHub
component: email automation type: bug
Dominant language
Python
Stars
119
Forks
76
Avg merge
9d 17h
Merged PRs (30d)
5

Description

Abridged traceback from a `DeclinedInstructorsAction`:

```
File "/webapps/amy.carpentries.org/repo/amy/autoemails/actions.py", line 205, in __call__ return self.email.send(fail_silently=False)
...
File "/webapps/amy.carpentries.org/repo/.venv/lib/python3.11/site-packages/anymail/utils.py", line 159, in parse_address_list
raise AnymailInvalidAddress(errmsg)
anymail.exceptions.AnymailInvalidAddress: Invalid email address '' parsed from '' in `reply_to`.```
```
We have a few templates with no 'reply-to' address - `declined-instructor-signups`, `profile-update`, `consents-new` - but the latter two aren't used.

Contributor guide

Open the contributing guide

Research direction

Start with amy/autoemails/actions.py at line 205 and reproduce the DeclinedInstructorsAction failure. Inspect the email templates declined-instructor-signups, profile-update, and consents-new to compare their reply-to settings. Done means templates without a reply-to address no longer fail when used in actions, while configured addresses continue to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.