carpedm20 / carpedm20/MemN2N-tensorflow

Weight sharing missing?

Open
#18 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
824
Forks
245
PR merge metrics
No merged PRs in 30d

Description

Hi,

Thanks for the code. I notice that in the original code, the weights of C are shared, as in https://github.com/facebook/MemNN/blob/946c4784b59dcf053bbbbb9637d6814bc152c276/MemN2N-lang-model/model.lua#L67-L74

However, I cannot find the weight sharing part in this code. Did I miss something? Thank you.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the linked MemN2N-lang-model/model.lua lines 67-74, then trace the TensorFlow implementation of the C weights. Confirm whether weight sharing is present; done means the discrepancy is clearly explained or the missing behavior is precisely identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, tensorflow
Domain
machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.