carpedm20 / carpedm20/BEGAN-tensorflow

Bug in trainer.build_model()?

Open
#39 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
924
Forks
229
PR merge metrics
No merged PRs in 30d

Description

Hi,

thanks for sharing the code. I have a question about the discriminator loss for real images - `self.d_loss_real` in `trainer.build_model()`. You compute it as
`self.d_loss_real = tf.reduce_mean(tf.abs(AE_x - x))`
Before that you compute `x` to be normalized versions of real images by using `x = norm_img(self.x)`, but `AE_x` is a de-normalized version of the discriminator output for `x`. Is it a bug, or am I missing something? I'm talking about [this](https://github.com/carpedm20/BEGAN-tensorflow/commit/458eb68997b95c8820a2ea874ef3e82f79812192) commit.

Thanks in advance,
Anastasia

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in trainer.build_model() and inspect the commit linked in the issue, focusing on norm_img(self.x), AE_x, and self.d_loss_real. Trace whether both tensors use the same scale, then document the conclusion and any required correction with a focused regression check if the repository provides one.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, tensorflow
Domain
machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.