carloscuesta / carloscuesta/gitmoji-cli

support `git commit` options within `gitmoji -c`

Open
#1,040 3 comments 0 reactions 0 assignees View on GitHub
feature
Dominant language
JavaScript
Stars
4.8k
Forks
212
PR merge metrics
No merged PRs in 30d

Description

### Description of the problem

```bash
$ gitmoji -v
8.0.0
```

Currently it is not possible to use `git commit` flags and options when calling `gitmoji -c`.

Because of that some super useful options like `git commit -S` to sign the commits is not possible to be used within that command.

### Solution

add the needed flags as optional parameters to the already supported flags.

### Alternatives

Currently it is possible to add some of the flags to the git global settings. E.g. with the example for `-S`

```bash
git config --global commit.gpgsign true
```

Furthermore (fast reading the code) I think it should be possible to have this functionality using the `--hook` flag.
`gitmoji --hook -S -m ...`. Need to verify.

This is possible but somehow not nice

### Additional context

For me in special the `-S` option is needed and useful. In many projects I want and need to sign commits and should be considered as best practice. For more information please consider https://dev.to/andreasaugustin/git-how-and-why-to-sign-commits-35dn

There are many more useful options which are currently suppressed. Happy to discuss.

### Validations

- [X] Follow our [Code of Conduct](https://github.com/carloscuesta/gitmoji-cli/blob/master/CODE_OF_CONDUCT.md)
- [X] Read the [Contributing Guide](https://github.com/carloscuesta/gitmoji-cli/blob/master/.github/CONTRIBUTING.md).
- [X] Check that there isn't already an issue requesting the same feature.

Contributor guide

Open the contributing guide

Research direction

Start by tracing how `gitmoji -c` parses its existing options and invokes `git commit`; the issue specifically calls out support for `-S` and other commit flags. Done means commit options can be passed through `gitmoji -c`, with coverage for the requested signing case and any documented supported forms.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.