carbon-design-system / carbon-design-system/devtools

Accordion stop bubbling hack

Open
#33 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
46
Forks
23
PR merge metrics
No merged PRs in 30d

Description

So I'm doing some stuff that's probably not the greatest to do to prevent accordions' clicks bubbling to the top. Ideally the react component in Carbon would allow for a stop propagation function to be triggered, but it doesn't seem to work when I put this hack in. I'm creating this ticket in hopes to keep this in mind, and either contribute back to Carbon or update if it ever gets a fix.

https://github.com/carbon-design-system/devtools/blob/master/App/popup/components/Main/index.js#L47-L55

Contributor guide

Open the contributing guide

Research direction

Start with App/popup/components/Main/index.js at lines 47-55 and inspect how the accordion click workaround is used. Then check the Carbon React accordion behavior and whether its stop-propagation support has changed; the issue is complete only when the workaround path and the intended Carbon-compatible approach are clearly resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.