captbaritone / captbaritone/webamp

Oscilloscope is only one pixel off the center (and it's showing a long duration of the waveform)

Open
#544 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
11.3k
Forks
796
PR merge metrics
No merged PRs in 30d

Description

![image](https://user-images.githubusercontent.com/38136789/38772140-2d4301ac-4030-11e8-8542-2fa8b19f6877.png)
As seen in the image (resized 4x), it's one pixel off.

![image](https://user-images.githubusercontent.com/38136789/38772154-85685b7a-4030-11e8-98bc-2ac991f869e5.png)
Also the waveform is too long, in WACUP/Winamp it's short enough to be _somewhat_ accurate to what's played, please test this against Winamp 2.9, as that could be different.

https://1drv.ms/u/s!AvtI52OneMJFgag1Ql6CmWCimGNbGQ

Contributor guide

No contributing guide indexed for this repository

Research direction

No file, test, or entry point is named. Start by locating the oscilloscope rendering and waveform-duration logic, then compare its centered pixel position and displayed waveform length with the screenshots and Winamp 2.9; done means the oscilloscope is centered and shows a similarly short, playback-representative waveform.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
audio-video-rtc, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.