captbaritone / captbaritone/webamp

Visualizer modes are being needlessly destroyed

Open
#1,295 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
11.3k
Forks
796
PR merge metrics
No merged PRs in 30d

Description

With this new change, comes a few new bugs.

As we change modes (either by cycling the modes, switching between windowshade and normal, toggling double size mode...), the visualizer is being reinitialized needlessly, whereas the previous implementation never did this.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the issue while cycling visualizer modes, switching windowshade and normal modes, and toggling double-size mode. Trace when the visualizer is initialized during those transitions; done means mode changes preserve the existing visualizer without needless reinitialization.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.