captbaritone / captbaritone/webamp

Equalizer Window: ON Button has the wrong dimension (2 pixels too wide)

Open
#1,190 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
11.3k
Forks
796
PR merge metrics
No merged PRs in 30d

Description

Hello!

So, I took the liberty of uploading this theme the other day...

https://skins.webamp.org/skin/75a086cef75b26371b184d28b9150860/d11amp059_theme.wsz/

Here, you will notice that the ON button is active, but at least one pixel of the AUTO button is illuminated as well.
So, at first, I suspected the theme to have a bug, but when I loaded this theme

https://skins.webamp.org/skin/47597ab8e5ffcd39686d455c10c3b436/Garfield.zip/

I saw the same effect of the ON button bleeding over into the AUTO button. (Albeit only being visible with the pressed Button)
I have not yet checked it against XMMS or WinAmp yet. Sorry.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the issue with the d11amp059 and Garfield skins linked in the report, using the equalizer window's ON and AUTO buttons. Trace the equalizer button rendering and compare the active ON dimensions with the adjacent AUTO button; done means the ON state no longer bleeds into AUTO for both skins.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.