captbaritone / captbaritone/webamp

Crossorigin and Credentials for Audio

Open
#1,139 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
11.3k
Forks
796
PR merge metrics
No merged PRs in 30d

Description

Hi,

when you creating audio element in code you fix crossorigin to anonymous `audio.crossOrigin = "anonymous";`.

This causes problem with servers, which would require some credentials to be included with requests, value `use-credentials` fixes this problem.
However just using it in all cases will probably break some other uses cases, because then there are more strict rules for URLs and CORS headers. Ideally this should be choice when creating Webamp.

P.S. Thanks for Webamp, it is cool, I have been using winamp for years in past century :-)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating where the audio element is created and where audio.crossOrigin is assigned. Trace how Webamp configuration is passed into that entry point, then define what option should select anonymous versus use-credentials and verify that existing audio behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
audio-video-rtc, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.