capistrano / capistrano/sshkit

Nested "on" blocks should raise or warn

Open
#352 4 comments 0 reactions 0 assignees View on GitHub
discuss! enhancement help wanted
Dominant language
Ruby
Stars
1.2k
Forks
257
PR merge metrics
No merged PRs in 30d

Description

From https://github.com/capistrano/sshkit/issues/348#issuecomment-220160838

> AFAIK nested on blocks were never considered in the design. The fact that it works at all is really just coincidence, due to how the SSHKit DSL is mixed into all objects. IMO it should raise an exception. You can open an SSHKit issue.

My personal opinion is that we should actually support it (take intersection of all role sets in the call stack), but until then, we should raise or warn when we find a nested `on` blocks.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.