capistrano / capistrano/sshkit

Bug: Background doesn't work as expected, should be deprecated and eventually removed

Open
#332 4 comments 0 reactions 0 assignees View on GitHub
discuss!
Dominant language
Ruby
Stars
1.2k
Forks
257
PR merge metrics
No merged PRs in 30d

Description

https://github.com/capistrano/sshkit/blob/6c81f53eec86443ea4f03fd87ae3350d4d4051ec/lib/sshkit/backends/abstract.rb#L59

The problem is that background simply `nohup` and backgrounds the process using the shell's job control `&`. More often than not, badly behaved daemons still block.

There's many hoops to jump through to ensure that your process behaves well when backgrounded, forked, nohupped, etc - and we can't whitelist programs that do it well, and blacklist those that can't.

Discussion is welcome, but I do think that `background()` should be removed from the DSL.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.