caolan / caolan/nodeunit

[Bug] reporter minimal doesn't throw "undone tests"

Open
#163 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.9k
Forks
359
PR merge metrics
No merged PRs in 30d

Description

Reporter minimal doesn't throw "undone tests" and so exit with 0 instead of 1.

``` shell
/test (master⚡) ./node_modules/nodeunit/bin/nodeunit --reporter minimal ./tests/my.test.js
my.test.js: ..% /test (master⚡) echo $?
0
/test (master⚡) ./node_modules/nodeunit/bin/nodeunit ./tests/my.test.js

my.test.js
✔ constructor
✔ _getKeywords

FAILURES: Undone tests (or their setups/teardowns):
- onKeywords

To fix this, make sure all tests call test.done()
/test (master⚡) echo $?
1
/test (master⚡)

```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.