caolan / caolan/magery

Make 'components' an explicit argument to render function

Open
#11 1 comment 0 reactions 1 assignee View on GitHub

@caolan is already working on this.

Since Jan 21, 2018.

Dominant language
JavaScript
Stars
56
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Currently components reference each other via this, but that can be confusing (particularly when not explicitly calling a constructor in an OO style).

See https://github.com/caolan/magery/issues/9#issuecomment-357526945 for an example of how this can easily cause confusion.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.