caolan / caolan/highland

Produce better error messages

Open
#94 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.4k
Forks
145
PR merge metrics
No merged PRs in 30d

Description

this discussion is a fork from #79 .

@caolan said

> we should probably make that a nicer error message! (pull requests welcome for that)

@greelgorke said:

> attempt is to check for the value being a highland stream (or feature-detect, but it's less reliable in our case) and to produce an error if it doesn't pass the check (instead of throwing)

@caolan also said:

> We currently don't wrap iterator (eg, map, filter...) calls with try/catch in order to pass those sync errors down the pipeline but we probably should!

Contributor guide

Open the contributing guide

Research direction

No file or test is named. Start by tracing the stream-value check and iterator calls such as map and filter discussed here, then clarify the intended error behavior with the maintainers. Done should mean that the agreed invalid-value and synchronous-error cases produce the specified messages or flow down the pipeline without being thrown.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
backend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.