caolan / caolan/highland

Make .end() behave like stream.end() ?

Open
#265 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.4k
Forks
145
PR merge metrics
No merged PRs in 30d

Description

Hi,

Highland.js .end function doesn't accept parameters, and just closes the stream, unlike stream.end, which accepts 1 parameter of data, send it, and then closes the stream.

Does it make sense to change highland.js end function to be more like node end function ?
I am building a lib, which provides it's users "smart" stream (e.g. highland streams), but end is not behaving the same.

Contributor guide

Open the contributing guide

Research direction

Start at Highland.js's .end entry point and compare its current behavior with Node.js stream.end, especially how data is accepted before closure. Define and test the intended parameter and shutdown semantics; done means Highland streams provide the agreed stream.end-compatible behavior without ambiguity.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
stream-processing
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.