caolan / caolan/highland

concat does not propagate events

Open
#137 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.4k
Forks
145
PR merge metrics
No merged PRs in 30d

Description

When two streams are concatted, events are not propagated do the resulting stream.

``` coffeescript
s1 = _ ["hello"]
s2 = _ ["world"]

s = s1 .concat s2

s.on "foo", (v) -> ... # Never invoked

s1.emit "foo", foo
```

Contributor guide

Open the contributing guide

Research direction

Start at the concat entry point in Highland's stream implementation and reproduce the issue with the provided s1, s2, and foo event snippet. Trace how events are handled on the concatenated stream; done means an event emitted by s1 reaches the listener attached to s, without breaking concatenation.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.