canyie / canyie/pine

prebuilt更新建议

Open
#42 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
1.5k
Forks
279
PR merge metrics
No merged PRs in 30d

Description

这都是两年前的prebuilt了 是时候更新一下了 (之前那你这个prebuilt,然后用到新的dex踩坑了一把)

然后有一个建议就是编译好的libpine_static.a文件给用户引用的应该修改一下 [JNI_OnLoad] (https://github.com/canyie/pine/blob/cf5335c00256b5c429db14372e51d6992203908e/core/src/main/cpp/jni_bridge.h#L11) 重命名一下(例如修改为Pine_JNI_OnLoad)以免链接的时候与用户原本的JNI_OnLoad冲突,这里提供两个方式修改,要么直接改源码,要么也不用改源码了直接编译好的成品用objcopy修改一下就好

```
objcopy --redefine-sym=JNI_OnLoad=Pine_JNI_OnLoad libpine.a
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.