canton7 / canton7/PropertyChanged.SourceGenerator

Generated code in latest version not compiling/missing OnPropertyChanged

Open
#39 7 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C#
Stars
168
Forks
20
PR merge metrics
No merged PRs in 30d

Description

**Description**
After upgrading to 1.1.0, `OnPropertyChanged` either does not get called, or `PropertyChanged.SourceGenerator.Internal.EventArgsCache.PropertyChanged_PropertyName` gets passed instead of property name.

**To Reproduce**
This only generated `OnPropertyChanging`, but not `OnPropertyChanged`.
```csharp
public sealed partial class TestModel
{
[Notify]
private decimal _total;
}
```

**Version Info**
- PropertyChanged.SourceGenerator version: 1.1.0
- Roslyn Version: Compiler version: '4.5.0-6.23127.3 (e2bc27d2)'. Language version: 11.0.

**Additional Info**
Upgrading to this version also caused various issues in Rider.
I had to clear caches/restart it multiple times to even reproduce the simple case.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.