canonical / canonical/vanilla-framework

Make non-semantic icon color context-sensitive

Open
#5,494 10 comments 0 reactions 2 assignees Claimed by @jmuzina View on GitHub
Priority: High Tier: Global Triaged: Pragma WG: Validated
Dominant language
HTML
Stars
983
Forks
216
Avg merge
3d 13h
Merged PRs (30d)
3

Description

## Component/pattern to amend

Icons
https://vanillaframework.io/docs/patterns/icons

## Visual

![Image](https://github.com/user-attachments/assets/a57c896b-3b9b-4c61-976a-83f5f1545a64)

![Image](https://github.com/user-attachments/assets/6bbe94e8-4a79-4908-a436-3e2c34952910)

![Image](https://github.com/user-attachments/assets/ff0b9a54-6318-47db-86af-b038b23e06f7)

![Image](https://github.com/user-attachments/assets/8ec2215d-1e9c-40d4-8c47-e42958295e48)

![Image](https://github.com/user-attachments/assets/67160cd7-e6ef-469e-b581-2b7407aa57ff)

## Context

Sometimes we have a situation where we want to show that an item is a link (going back, external link) and to highlight the action I use the blue link colour for text and I want to align the icon that stands next to it. I think in these situations it would be beneficial to allow icons to be blue as well. Similarly sometimes I use icons as muted black for icons to establish hierarchy. I see customisation of icons is discouraged and potentially will be deprecated, I wanted to ask for reasoning and to rethink that decision.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.