canonical / canonical/vanilla-framework

Logo Section Comp with Links

Open
#5,388 3 comments 0 reactions 0 assignees View on GitHub
P3 Needs decision P3 Triaged WG: Validated
Dominant language
HTML
Stars
983
Forks
216
Avg merge
3d 13h
Merged PRs (30d)
3

Description

## Component/pattern to amend

[Logo section](https://www.figma.com/design/Y0cqKbTG4rejU9xm2oh5pR/%F0%9F%92%A0-Vanilla---Core-component-library?node-id=3680-21862&t=wofmadQoOnmmvp5d-1)

## Visual

Provide a screenshot or link to a prototype of your pattern amendment.

Screenshot 2024-10-14 at 16 41 03

## Context

Current comp handles logos but not when there are links associated with it. This has often been a fallback option, but doesn't follow the 12-col grid and so spacing looks inconsistent:
Screenshot 2024-10-14 at 16 46 32

The suggestion I'm putting forward adds links while following the typical layout, so should look neater.

Contributor guide

Open the contributing guide

Research direction

Review the linked Figma Logo section design and the current Logo section component, then compare its link layout with the 12-column grid shown in the issue. Done means the logo section supports associated links and follows the proposed spacing and layout consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, html, sass
Domain
design, frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.