canonical / canonical/vanilla-framework

Discuss/Investigate Font Weight of Inline Code inside Headers

Open
#5,266 2 comments 0 reactions 0 assignees View on GitHub
P3 Triaged Triaged: v4
Dominant language
HTML
Stars
983
Forks
216
Avg merge
3d 13h
Merged PRs (30d)
3

Description

## Component/pattern to amend

Base typography (inline code)

## Context

@lyubomir-popov [noticed](https://github.com/canonical/vanilla-framework/pull/5242#issuecomment-2260689639) that `` elements inside of header elements use inline code font weight. He proposed we may be able to set their `font-weight` to `inherit` to solve this.

This could be adjusted [here](https://github.com/canonical/vanilla-framework/blob/78863b6e8868704c7fa2efb5fb4d72f01259a9af/scss/_base_code.scss#L15), but discussion / investigation would be needed to see what the desired behavior should be, as this would mean that inline code elements no longer control their own font weight.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing scss/_base_code.scss around line 15 and the linked pull request discussion about inline code inside headers. Investigate the desired font-weight behavior for these elements and confirm it across relevant header and inline-code patterns. Done means the behavior is agreed and the base typography styling is amended accordingly.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, sass
Domain
design, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.