canonical / canonical/vanilla-framework
Add our p-section--shallow spacing to h1,h2s by default
- Dominant language
- HTML
- Stars
- 983
- Forks
- 216
- Avg merge
- 3d 13h
- Merged PRs (30d)
- 3
Description
Wrapping headings in p-section--shallow is one of the most comment QA comments I have to leave, which leads me to think there's room for improvement. My propoosal:
- add it by default on h1, h2
- provide a class that is added on a parent, and allows us to reduce that margin-bottom in places like documentation sites, where we get consistent requests to make things significantly denser. We can then further expand this to affect font-sizes, also a requirement from the documentation team
Before:


After:


Contributor guide
Research direction
Start by locating the existing p-section--shallow styles and the default h1 and h2 rules in the Vanilla Framework source. Review the examples shown in the issue, then define the heading defaults and parent class behavior so headings are shallow by default while documentation layouts can become denser; done means both spacing cases are covered consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, html, sass
- Domain
- design, frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100