canonical / canonical/vanilla-framework

Align colors for Input background and Code background

Open
#5,130 2 comments 0 reactions 0 assignees View on GitHub
P3 Triaged Vanilla WG WG: Validated
Dominant language
HTML
Stars
984
Forks
216
Avg merge
3d 13h
Merged PRs (30d)
3

Description

## Component/pattern to amend

[Forms input](https://vanillaframework.io/docs/examples/base/forms/input?theme=light)

[Code snippet](https://vanillaframework.io/docs/examples/patterns/code-snippet/dropdown?theme=light)

This is applicable to all inputs and code snippets.

## Visual
![Screenshot 2024-06-12 at 13 58 27](https://github.com/canonical/vanilla-framework/assets/157808111/2d2f0184-afdb-4dff-965f-dc735b92a777)

![Screenshot 2024-06-12 at 13 58 46](https://github.com/canonical/vanilla-framework/assets/157808111/5f54f767-b09b-4447-88b2-a5b8783b355a)

![Screenshot 2024-06-12 at 14 04 06](https://github.com/canonical/vanilla-framework/assets/157808111/eaba3b04-f707-46a3-a9d7-0ad6db0170bc)

![Screenshot 2024-06-12 at 14 04 31](https://github.com/canonical/vanilla-framework/assets/157808111/87a58cd7-4c3d-483f-9d1a-a5fba60ea309)

[Figma link](https://www.figma.com/design/K1xrbxlcBnlqgbveO9lXMU/24.04-Support-portal-improvements?node-id=5108-5452&t=CEfElMqyyLi5NT1V-1)

## Context
There is a very slight color difference between Background-input: #F5F5F5 and Background-code: #F7F7F7.
My proposal is to align the colors and use the same color in both components. My preference is light color that is used for code: #F7F7F7, but open to both options.

Contributor guide

Open the contributing guide

Research direction

Start with the linked Forms input and Code snippet examples and inspect how their backgrounds are defined. Align the two component backgrounds to one color, then verify that the same color appears across all inputs and code snippets in the linked examples.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, sass
Domain
design, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.