canonical / canonical/vanilla-framework
Two-column modal (forms)
- Dominant language
- HTML
- Stars
- 983
- Forks
- 216
- Avg merge
- 3d 13h
- Merged PRs (30d)
- 3
Description
## Pattern to amend
[Modal](https://vanillaframework.io/docs/patterns/modal)
## Visual
This is the visual @lyubomir-popov did for the form on MicroK8s, [here on Figma](https://www.figma.com/file/sGeCjFvA1kV9Kmvg2S2VBn/23.10-U.com---AI-bubble?type=design&node-id=976-3052&mode=design&t=0u8u23DUGctpbTB3-0):
Actual working example: go to https://canonical.com/data/spark and click on "Contact us"
## Context
Following the new visual styles, we are using a two column layout for forms within modals. We should define how it should behave.
* The close "x" button should always be visible, at least with the two column layout. Is this ok visually?
* I'm inclined to make only the form scrollable. What happens though if content on the first column is long?
* I think the modal shouldn't have margins on mobile, at least in this use case.
Prompted by @carkod in https://github.com/canonical/canonical.com/pull/1044#issuecomment-1740706457
Contributor guide
Assessment
This issue has not been assessed yet.