canonical / canonical/vanilla-framework

Fix alignment of the icon with text in new `u-has-icon` utility

Open
#4,695 2 comments 0 reactions 0 assignees View on GitHub
Bug 🐛 P3 Triaged Triaged: Pragma
Dominant language
HTML
Stars
983
Forks
216
Avg merge
3d 13h
Merged PRs (30d)
3

Description

It seems that the icons are not exactly aligned properly when using new `u-has-icon` utility.

We should verify if that is correct and adjust if needed.

image

It's especially true for social icons, that by default use 1.5 rem size instead of 1rem.

More context: https://github.com/canonical/vanilla-framework/pull/4693#issuecomment-1462140812

Contributor guide

Open the contributing guide

Research direction

Search the framework source for the `u-has-icon` utility and its social-icon styles, then review the screenshot and linked pull request comment for context. Reproduce the misalignment, verify behavior with the 1.5rem social icons, and confirm that the corrected rendering is covered by the relevant framework checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, sass
Domain
design, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.