canonical / canonical/vanilla-framework

Active and hover state change on light theme

Open
#4,593 7 comments 0 reactions 0 assignees View on GitHub
Feature 🎁 P3 Triaged Review: Code needed Triaged: v4
Dominant language
HTML
Stars
983
Forks
216
Avg merge
3d 13h
Merged PRs (30d)
3

Description

## Pattern to amend

Active & Hover state on light themes.

## Visual
Screen Shot 2022-10-18 at 3 54 43 PM

Screen Shot 2022-10-18 at 3 55 17 PM

[Clickable Prototype](https://www.figma.com/proto/FDYbZCtiX8CfNMVieKvVrB/Audit?page-id=209%3A115140&node-id=211%3A115142&viewport=574%2C287%2C0.41&scaling=scale-down&starting-point-node-id=211%3A115142)

## Context

In what context does your amendment solve a problem?
1. current segmented control active state looks inactive when limited to 2 choices. This improves usability.

2. This improves the visual weight of active components even when resized so it doesn't need to be compensated down.

Screen Shot 2022-10-18 at 5 22 46 PM

Contributor guide

Open the contributing guide

Research direction

Start with the two screenshots and the linked Figma clickable prototype to understand the intended active and hover states for light themes. Locate the segmented control and related light-theme styles in the Vanilla Framework source, then compare the rendered states against the references. Done means the active and hover treatments match the prototype across the described component sizes.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, html, sass
Domain
design, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.