canonical / canonical/vanilla-framework

Accordion: max-width is not working properly in the headings.

Open
#4,563 10 comments 0 reactions 0 assignees View on GitHub
Bug 🐛 P3 Triaged Triaged: Pragma
Dominant language
HTML
Stars
983
Forks
216
Avg merge
3d 13h
Merged PRs (30d)
3

Description

**Describe the bug**

1. `max-width` needs to be added for the case texts get longer in the headings.
after adding `max-width` to the button locally, the background color is not going all the way when its hovered over because the hover effect is applied to the button.
image
image
Screenshot 2022-09-02 at 11 31 31 am

2. `span` needs to be added inside the buttons to fix this hover effect bug mentioned above.
after adding `span` inside the button locally, `max-width` is not working as `span` has inline attribute. so I had to add `display: inline-block`
after adding `display: inline-block` to the `span`, the position of the icon in the button moves down.
Screenshot 2022-09-02 at 11 41 41 am

Contributor guide

Open the contributing guide

Research direction

Start by locating the Accordion heading button styles in the Vanilla Framework and reproduce the issue with a long heading. Check the hover background coverage, max-width behavior, and icon alignment; done means long headings constrain correctly while the hover state spans the intended area without shifting the icon.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, sass
Domain
design, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.