canonical / canonical/vanilla-framework

Table cells with icons overflow with space above

Open
#3,703 6 comments 0 reactions 0 assignees View on GitHub
Bug 🐛 P3 Triaged Priority: Medium Triaged: Pragma
Dominant language
HTML
Stars
983
Forks
216
Avg merge
3d 13h
Merged PRs (30d)
3

Description

**Describe the bug**
When the cell contents overflow with an icon the icon pushed the contents down a line which is undesirable.

**To Reproduce**

Steps to reproduce the behaviour:

1. Go to https://vanillaframework.io/docs/base/tables#icons
2. Inspect and edit the content of the Failed cell to extend its contents
3. See that the content of the cell ellipse but drops down a line.

**Expected behaviour**
Contents should ellipse on the same line as the icon.

**Screenshots**
![image](https://user-images.githubusercontent.com/1413534/114610578-fc310d80-9c97-11eb-9685-a65a5ff5a205.png)

**Additional context**
Adding cloud icons next to the model list on jaas-dashboard:
![image](https://user-images.githubusercontent.com/1413534/114611089-8d07e900-9c98-11eb-932d-03e9105135aa.png)

Contributor guide

Open the contributing guide

Research direction

Start with the table icons example at https://vanillaframework.io/docs/base/tables#icons and inspect the styles for the Failed cell and its icon. Reproduce the overflow by extending the cell contents; done means the text ellipsizes on the same line as the icon without being pushed down.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, html, sass
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.