canonical / canonical/vanilla-framework
.p-heading-icon element classes work outside of the block
Open
P3 Triaged
Priority: Medium
Review: Code needed
Triaged: Pragma
- Dominant language
- HTML
- Stars
- 983
- Forks
- 216
- Avg merge
- 3d 13h
- Merged PRs (30d)
- 3
Description
The internal elements of the heading icon pattern work without being nested within its block class. For example `.p-heading-icon__img`.
This leads to people using them as utilities which results in untested and unexpected styling.
Contributor guide
Research direction
Start by locating the heading icon pattern source and any related tests. Check how the internal element selectors are currently defined and verify that the finished change scopes them to the block and covers the behavior with tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, html, sass
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100