canonical / canonical/vanilla-framework

Fix issues with specificity order in Vanilla

Open
#3,016 3 comments 0 reactions 0 assignees View on GitHub
Epic Maintenance 🔨 P3 Triaged Priority: High Triaged: Pragma
Dominant language
HTML
Stars
983
Forks
216
Avg merge
3d 13h
Merged PRs (30d)
3

Description

Follow up to Stylelint migration #3010

Stylelint default rules enforce following specificity order in the code.
In most places we do comply with this, others were simple to fix, but there are some parts of the code that fail on that and are not easy to fix.

Currently we have this rule set up as warning, but it's unnecessary showing up in the stylelint output, and recently also starts to show up in ALL pull requests due to GH new feature of showing annotations from GitHub actions.

Screenshot 2020-04-27 at 16 31 13

We should try to fix these files to make them comply to specificity order or disable this rule in the sections that can't be fixed.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the Vanilla styles and the Stylelint specificity-order warnings referenced in the issue. Identify the affected sections, then either bring their declarations into the required order or disable the rule only where fixing is not practical; done means the unnecessary warnings no longer appear in Stylelint or GitHub Actions output.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, sass
Domain
frontend, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.