canonical / canonical/valkey-operator

Backups: Two units creating a backup at the same time could overwrite the backup file

Open
#77 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
3
Forks
2
Avg merge
3d 11h
Merged PRs (30d)
25

Description

Backups can be created on all units of a Valkey deployment (functionality added in #59). If the `create-backup` action is run at the exact same time on multiple units, they will create a backup with the same filename / backup-id, and the file uploaded to S3 storage might be corrupt/overwritten.

For details or reproducability see the review comment: https://github.com/canonical/valkey-operator/pull/59#pullrequestreview-4577257640

Contributor guide

Open the contributing guide

Research direction

Start with the `create-backup` action and the reproducibility details in the review comment on pull request #59. Run the action concurrently on multiple deployment units and inspect the S3 backup objects and identifiers. Done means simultaneous backups no longer corrupt or overwrite one another.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
databases, distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.