canonical / canonical/secboot

Make use of `testing.Short()` to skip long-running tests

Open
#354 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
23
Forks
29
Avg merge
2d 8h
Merged PRs (30d)
2

Description

We currently have a mechanism to skip various long-running tests by
putting them into a dedicated suite which is skipped if a certain environment
variable is set. We have 2 environment variables - `NO_EXPENSIVE_CRYPTSETUP_TESTS`
and `NO_ARGON2_TESTS`, and the latter makes no sense anyway. We still
test some Argon2 functionality with this set, it just results in tests that take
a long time being skipped.

We should instead convert these suites to just calling `testing.Short()` which
can be set with the `-test.short` commandline argument.

Contributor guide

Open the contributing guide

Research direction

Search the test suites for NO_EXPENSIVE_CRYPTSETUP_TESTS and NO_ARGON2_TESTS, then read how those environment variables currently control long-running tests. Replace that mechanism with testing.Short() and verify the suites are skipped when running with -test.short while the Argon2 functionality tests still run.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.