canonical / canonical/secboot

Don't try to be too clever on failure in UnsealFromTPM

Open
#105 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
23
Forks
29
Avg merge
2d 8h
Merged PRs (30d)
2

Description

Currently, UnsealFromTPM tries to determine between an invalid key file or a TPM provisioning issue, and executePolicySession goes even further - trying to determine whether the static metadata or PCR policy metadata is invalid, although that isn't exposed at the moment. I think this should just return a single error on unseal failure (InvalidKeyFile), and then it should be up to the running system to perform additional diagnostics (see https://github.com/snapcore/secboot/issues/33)

Contributor guide

Open the contributing guide

Research direction

Start at UnsealFromTPM and executePolicySession, the entry points named in the issue, and trace how each currently distinguishes unseal and policy metadata failures. Done means unseal failure returns the single InvalidKeyFile error, with additional diagnostics left to the running system as described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
security
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.