canonical / canonical/react-components
Consider removing testing-library/no-node-access lint rule
Open
P3 Triaged
Question ❓
Triaged: new architecture
- Dominant language
- TypeScript
- Stars
- 151
- Forks
- 74
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 11
Description
To build a component library around Vanilla we really care about the class names, visual elements, node order etc. not just the accessible labels and roles
To do this we often need to access the DOM directly so a lot of tests require disabling `testing-library/no-node-access` so possibly we should just disable that lint rule (though I could be overlooking some way of checking these things with RTL).
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.